Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] fixes #66252 correct use of egrep to parse semanage output #66253

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ndptech
Copy link

@ndptech ndptech commented Mar 21, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes: #66252

Previous Behavior

Attempting to run selinux.fcontext_policy_present with a filecontext which is a shorter version of one which is already defined would fail with

File context for ... is not defined

New Behavior

The state will now apply correctly

Merge requirements satisfied?

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@ndptech ndptech requested a review from a team as a code owner March 21, 2024 13:54
@ndptech ndptech requested review from felippeb and removed request for a team March 21, 2024 13:54
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title fixes #66252 correct use of egrep to parse semanage output [3006.x] fixes #66252 correct use of egrep to parse semanage output Mar 21, 2024
dwoz
dwoz previously requested changes Jun 21, 2024
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter errors need to be fixed.

Copy link

welcome bot commented Oct 21, 2024

Congratulations on your first PR being merged! 🎉

@lkubb
Copy link
Contributor

lkubb commented Oct 24, 2024

This has introduced failing tests, see https://github.com/saltstack/salt/actions/runs/11499408739/job/32010027668 for example

@dmurphy18
Copy link
Contributor

@lkubb Have fix in #66986, awaiting review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants