-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] fixes #66252 correct use of egrep to parse semanage output #66253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
fixes #66252 correct use of egrep to parse semanage output
[3006.x] fixes #66252 correct use of egrep to parse semanage output
Mar 21, 2024
dwoz
approved these changes
Jun 21, 2024
dwoz
approved these changes
Jun 21, 2024
dwoz
previously requested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter errors need to be fixed.
dmurphy18
approved these changes
Jul 11, 2024
Congratulations on your first PR being merged! 🎉 |
This has introduced failing tests, see https://github.com/saltstack/salt/actions/runs/11499408739/job/32010027668 for example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes: #66252
Previous Behavior
Attempting to run
selinux.fcontext_policy_present
with a filecontext which is a shorter version of one which is already defined would fail withFile context for ... is not defined
New Behavior
The state will now apply correctly
Merge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.